[webkit-reviews] review granted: [Bug 60210] REGRESSION (WebKit2): Windowed plugins don't scroll at the same speed as the rest of the page : [Attachment 92322] Clip and reposition windowed plugins when the UI process paints

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 60210: REGRESSION (WebKit2): Windowed plugins don't scroll at the same
speed as the rest of the page
https://bugs.webkit.org/show_bug.cgi?id=60210

Attachment 92322: Clip and reposition windowed plugins when the UI process
paints
https://bugs.webkit.org/attachment.cgi?id=92322&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=92322&action=review

> Source/WebKit2/UIProcess/win/WebView.cpp:1542
> +enum RedrawOrNot { DoNotRedraw, Redraw };
> +static void setWindowRegion(HWND window, PassOwnPtr<HRGN> popRegion,
RedrawOrNot redrawOrNot)
> +{

Given this is only called in one place, why not always redraw? Do you have
plans to use this elsewhere?