[webkit-reviews] review granted: [Bug 59984] Need a way to determine if the main thread has been initialized. : [Attachment 92327] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 59984: Need a way to determine if the main thread has been initialized.
https://bugs.webkit.org/show_bug.cgi?id=59984

Attachment 92327: Patch
https://bugs.webkit.org/attachment.cgi?id=92327&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=92327&action=review

> Source/JavaScriptCore/wtf/MainThread.cpp:253
> +bool internalIsMainThreadInitialized()
> +{
> +#ifndef NDEBUG
> +    return mainThreadInitialized;
> +#else
> +    return false;
> +#endif
> +}

It doesn’t make sense to have this return false in NDEBUG builds. Maybe put a
CRASH() here instead or in addition?