[webkit-reviews] review granted: [Bug 60016] [GTK] WidgetGtk setFocus can not access directly the widget in WK2 : [Attachment 92056] Proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 60016: [GTK] WidgetGtk setFocus can not access directly the widget in WK2
https://bugs.webkit.org/show_bug.cgi?id=60016

Attachment 92056: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=92056&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92056&action=review

Great stuff.

> Source/WebCore/platform/gtk/WidgetGtk.cpp:69
> +    Frame* frame = Frame::frameForWidget(this);
> +    if (frame) {

This can just be:
if (Frame* frame = Frame::frameForWidget(this)) {

or an  early return.

> Source/WebCore/platform/gtk/WidgetGtk.cpp:71
> +	   Page* page = frame->page();
> +	   page->chrome()->focus();

Also should just be frame->page()->chrome()->focus();