[webkit-reviews] review denied: [Bug 59960] CoreIPC/ArgumentDecoder should use aligned memory for its internal copy of data : [Attachment 92080] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 3 10:28:38 PDT 2011


Anders Carlsson <andersca at apple.com> has denied Siddharth Mathur
<siddharth.mathur at nokia.com>'s request for review:
Bug 59960: CoreIPC/ArgumentDecoder should use aligned memory for its internal
copy of data
https://bugs.webkit.org/show_bug.cgi?id=59960

Attachment 92080: Patch
https://bugs.webkit.org/attachment.cgi?id=92080&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=92080&action=review

> Source/WebKit2/ChangeLog:1
> +2011-05-03  Siddharth Mathur  <siddharth mathur>

No e-mail address here.

> Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.cpp:71
> +    m_buffer = roundUpToAlignment(m_allocatedBase, expectedAlignment);

If you want, you can assert that m_buffer is aligned here.


More information about the webkit-reviews mailing list