[webkit-reviews] review denied: [Bug 56826] [Qt] Implement fullscreen playback for the GStreamer backend. : [Attachment 86481] V3 with style fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 31 06:54:55 PDT 2011


Benjamin Poulain <benjamin at webkit.org> has denied Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 56826: [Qt] Implement fullscreen playback for the GStreamer backend.
https://bugs.webkit.org/show_bug.cgi?id=56826

Attachment 86481: V3 with style fixes
https://bugs.webkit.org/attachment.cgi?id=86481&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86481&action=review

r- because of a massive style problem ;)
And maybe a little because this is not tested and you don't say why :)

> Source/WebCore/platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:50
> +    HTMLVideoElement *m_mediaElement;

Andreas: Style issue.


More information about the webkit-reviews mailing list