[webkit-reviews] review granted: [Bug 57538] Web Inspector: CSS domain - make a "range" object, get rid of "properties" object for Style objects : [Attachment 87708] [PATCH] Remove inadvertently added blank line

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 31 06:57:51 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 57538: Web Inspector: CSS domain - make a "range" object, get rid of
"properties" object for Style objects
https://bugs.webkit.org/show_bug.cgi?id=57538

Attachment 87708: [PATCH] Remove inadvertently added blank line
https://bugs.webkit.org/attachment.cgi?id=87708&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87708&action=review

> LayoutTests/inspector/styles/styles-source-offsets.html:12
> +    function rangeText(range)

Can you move this method into a common file for inspector CSS tests?

> LayoutTests/inspector/styles/styles-source-offsets.html:33
> +	   InspectorTest.addResult(header + " [" + style.range.start  + "-" +
style.range.end + "]");

Please use rangeText instead.


More information about the webkit-reviews mailing list