[webkit-reviews] review denied: [Bug 55927] Emulate shebang on Win32 : [Attachment 87621] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied  review:
Bug 55927: Emulate shebang on Win32
https://bugs.webkit.org/show_bug.cgi?id=55927

Attachment 87621: Patch
https://bugs.webkit.org/attachment.cgi?id=87621&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87621&action=review

>> Tools/Scripts/webkitpy/common/config/ports.py:47
>> +	def interpreter_for_script(cls, script_path):
> 
> Maybe we should put this in executive.py?  It's a win32 feature, not releated
to any specific webkit port.

You should pass in a FileSystem for mocking.  Then your test doesn't need to
even write out to disk if you use a MockFileSystem.

Please be sure to make that change before landing.