[webkit-reviews] review granted: [Bug 55927] Emulate shebang on Win32 : [Attachment 87621] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 55927: Emulate shebang on Win32
https://bugs.webkit.org/show_bug.cgi?id=55927

Attachment 87621: Patch
https://bugs.webkit.org/attachment.cgi?id=87621&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87621&action=review

This patch is great!

> Tools/Scripts/webkitpy/common/config/ports.py:47
> +    def interpreter_for_script(cls, script_path):

Maybe we should put this in executive.py?  It's a win32 feature, not releated
to any specific webkit port.

> Tools/Scripts/webkitpy/common/config/ports.py:66
> +	   # Win32 does not suppot shebang. We need to detect the interpreter
ourself.

support