[webkit-reviews] review granted: [Bug 52703] REGRESSION: Java applet fails to load when <object> has a classid attribute : [Attachment 87664] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 52703: REGRESSION: Java applet fails to load when <object> has a classid
attribute
https://bugs.webkit.org/show_bug.cgi?id=52703

Attachment 87664: Patch
https://bugs.webkit.org/attachment.cgi?id=87664&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87664&action=review

Nice fix!

> Source/WebCore/ChangeLog:5
> +	   REGRESSION: Java applet fails to load from within Adobe Flash-player
environment

Please update the bug title.

> Source/WebCore/ChangeLog:13
> +	   In r70748 we removed our mapping of several known ActiveX classids
to
> +	   MIME types. In the process of doing so, we decided to strictly
adhere
> +	   to HTML5 by rendering fallback content whenever we encounter an
object
> +	   with a non-empty, non-recognized classid. This turned out to be too
> +	   strict, as some plug-ins (e.g. Java and Qt application plug-ins)
co-opt
> +	   the classid attribute to store valid, plug-in specific bits.

If this patch makes us diverge from the spec, please don't land it without
filing a bug in HTML5 Bugzilla (no need to wait for its resolution IMO).

> LayoutTests/ChangeLog:5
> +	   REGRESSION: Java applet fails to load from within Adobe Flash-player
environment

Please update the bug title.