[webkit-reviews] review granted: [Bug 57379] Clean up WK1 key event handling logic : [Attachment 87405] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 57379: Clean up WK1 key event handling logic
https://bugs.webkit.org/show_bug.cgi?id=57379

Attachment 87405: proposed patch
https://bugs.webkit.org/attachment.cgi?id=87405&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87405&action=review

> Source/WebKit/mac/WebView/WebHTMLView.mm:5446
> +    // Avoid an infinite loop that would occur if executing a command saved
it back.

I don’t understand the phrase “saved it back”.

> Source/WebKit/mac/WebView/WebHTMLView.mm:5453
> +	   if (commands[i].commandName == "insertText:")

I’d be happier if we didn’t have multiple copies of the insertText: selector
string, and instead used a constant.