[webkit-reviews] review granted: [Bug 56128] REGRESSION (r80052): ~25% regression on v8-splay in-browser : [Attachment 87406] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 56128: REGRESSION (r80052): ~25% regression on v8-splay in-browser
https://bugs.webkit.org/show_bug.cgi?id=56128

Attachment 87406: Patch
https://bugs.webkit.org/attachment.cgi?id=87406&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87406&action=review

> Source/JavaScriptCore/runtime/Heap.cpp:386
> -    size_t proportionalBytes = static_cast<size_t>(1.5 *
m_markedSpace.size());
> +    size_t proportionalBytes = 2 * m_markedSpace.size();

It’s unclear where the constant 2 comes from. Your comments in change log talk
about 1X vs. .5X so there is obviously something going on here that I just
can’t spot. A comment explaining what we are accomplishing by multiplying by 2
and why 2 is the right value could be quite helpful.