[webkit-reviews] review granted: [Bug 57375] cleanup rebaseline-chromium-webkit-tests : [Attachment 87391] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 57375: cleanup rebaseline-chromium-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=57375

Attachment 87391: Patch
https://bugs.webkit.org/attachment.cgi?id=87391&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87391&action=review

> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:364
> +    def _extract_and_add_new_baseline(self, test, zip_file):

This still needs more splitting. :)

> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:398
> +	       if 0 != self._scm.add(expected_fullpath, return_exit_code=True):


0?

> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:459
> +	       else:

webkit doens't else after return.