[webkit-reviews] review denied: [Bug 57337] Fix compilation with Solaris 10/Sun Studio 12 CC : types must match on ?: : [Attachment 87320] Proposed patch which compiles correctly in qt-4.7.2 with webkit enabled on Solaris 10 with SS12 C++ compiler

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 29 13:04:51 PDT 2011


Eric Seidel <eric at webkit.org> has denied Ben Taylor
<bentaylor.solx86 at gmail.com>'s request for review:
Bug 57337: Fix compilation with Solaris 10/Sun Studio 12 CC : types must match
on ?:
https://bugs.webkit.org/show_bug.cgi?id=57337

Attachment 87320: Proposed patch which compiles correctly in qt-4.7.2 with
webkit enabled on Solaris 10 with SS12 C++ compiler
https://bugs.webkit.org/attachment.cgi?id=87320&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
We don't use c-style casts in WebKit.  static_cast is your friend. :)  How is
style() not a RenderStyle?


More information about the webkit-reviews mailing list