[webkit-reviews] review denied: [Bug 56924] [Qt] Fix Api tests for QWebPage on symbian : [Attachment 86620] first try

[bugzilla-daemon at webkit.org]

Alexis Menard <alexis.menard at openbossa.org> has denied yi shen
<yi.4.shen at nokia.com>'s request for review:
Bug 56924: [Qt] Fix Api tests for QWebPage on symbian
https://bugs.webkit.org/show_bug.cgi?id=56924

Attachment 86620: first try
https://bugs.webkit.org/attachment.cgi?id=86620&action=review

------- Additional Comments from Alexis Menard <alexis.menard at openbossa.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86620&action=review

A quick look tells me that the html code used as reference is the same except
for the font-family. Could you use instead QString::arg and specify a different
arg for either Symbian or other platforms? I'm wondering also if you could get
the current font used so that we don't need to add ifdef at all.

> Source/WebKit/qt/ChangeLog:8
> +	   Modified test case to use font 'NOkia Sans S60' on Symbian.

Typo :D I believe it's Nokia not NOkia.