[webkit-reviews] review granted: [Bug 57354] Make update-webkit-localizable-strings work with WebKit2 : [Attachment 87359] Proposed Change

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Timothy Hatcher <timothy at apple.com>'s
request for review:
Bug 57354: Make update-webkit-localizable-strings work with WebKit2
https://bugs.webkit.org/show_bug.cgi?id=57354

Attachment 87359: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=87359&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87359&action=review

It seems weird that WebLocalizableStrings.h is copied from LoaderRunLoopCF.h.
Is that a git thing?

> Source/WebCore/platform/network/cf/LoaderRunLoopCF.h:32
> -#error This code is not needed on platforms other than Windows, because main
thread's CFRunLoop can be used.
> +#error This code is not needed on platforms other than Windows, because the
CFRunLoop from the main thread can be used.

This change seems unrelated.