[webkit-reviews] review granted: [Bug 57338] Start to clean up BidiResolver::createBidiRunsForLine so that mere mortals can understand it : [Attachment 87316] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 57338: Start to clean up BidiResolver::createBidiRunsForLine so that mere
mortals can understand it
https://bugs.webkit.org/show_bug.cgi?id=57338

Attachment 87316: Patch
https://bugs.webkit.org/attachment.cgi?id=87316&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87316&action=review

> Source/WebCore/platform/text/BidiResolver.h:525
> +inline void BidiResolver<Iterator,
Run>::updateStatusLastFromCurrentDirection(WTF::Unicode::Direction dirCurrent)

Nit: Should we rename dirCurrent to currentDirection?