[webkit-reviews] review denied: [Bug 47636] AX: GTK: ARIA role is not respected on <p> <label> <div> and <form> : [Attachment 87292] Patch proposal + Layout test

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 47636: AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
https://bugs.webkit.org/show_bug.cgi?id=47636

Attachment 87292: Patch proposal + Layout test
https://bugs.webkit.org/attachment.cgi?id=87292&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=87292&action=review

> Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:494
> +	   if (node && coreObject->ariaRoleAttribute() == UnknownRole) {

I think you should add ParagraphRole, LabelRole and so on to WebCore. Then you
could just use roleValue() and you won't have to query the node of the renderer
or check that it's a render object (which we should be trying to avoid). 
Those roles would be mapped to NSAccessibilityGroupRole on mac