[webkit-reviews] review requested: [Bug 47636] AX: GTK: ARIA role is not respected on <p> <label> <div> and <form> : [Attachment 87292] Patch proposal + Layout test

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 47636: AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
https://bugs.webkit.org/show_bug.cgi?id=47636

Attachment 87292: Patch proposal + Layout test
https://bugs.webkit.org/attachment.cgi?id=87292&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Attaching patch proposal + Layout test.

Note: the patch is basically about adding an extra condition to the 'if'
statement.

-    if (axObject->isAccessibilityRenderObject()) {
-	 Node* node =
static_cast<AccessibilityRenderObject*>(axObject)->renderer()->node();
-	 if (node) {
+    if (coreObject->isAccessibilityRenderObject()) {
+	 Node* node =
static_cast<AccessibilityRenderObject*>(coreObject)->renderer()->node();
+	 if (node && coreObject->ariaRoleAttribute() == UnknownRole) {

Then I also made the most of this patch to rename the axObject variable
(normally used to refer instances of AtkObject) to coreObject, which is the
normal variable name used for instances of AccessibilityObject. I know it
messes up a little bit the patch but in the long term it makes IMHO the code
cleaner and, after all, the patch is not that big and complex to consider it
unreviewable, I think :-)