[webkit-reviews] review granted: [Bug 56918] [Qt] Teach build-jsc how to build JavaScriptCore on Qt : [Attachment 87130] build-jsc for Qt

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has granted Gabor Loki <loki at webkit.org>'s
request for review:
Bug 56918: [Qt] Teach build-jsc how to build JavaScriptCore on Qt
https://bugs.webkit.org/show_bug.cgi?id=56918

Attachment 87130: build-jsc for Qt
https://bugs.webkit.org/attachment.cgi?id=87130&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=87130&action=review

I'm sure if it works with a little fix I suggested, but it is a little 
nasty hack, because the original code was hacked in itself.

r=me to go ahead, but we really need a serious refactor for buildQMakeProject()
in the near future.

> Tools/Scripts/webkitdirs.pm:1637
>      if (grep { $_ eq "CONFIG+=webkit2"} @buildArgs) {
>	   push @subdirs, "WebKit2";
>	   if ( -e sourceDir() ."/Tools/DerivedSources.pro" ) {

We need one more if (!$project) guard to avoid building WebKit2, MiniBrowser
and WTR.