[webkit-reviews] review granted: [Bug 56859] Reduce float iteration in logicalLeft/RightOffsetForLine : [Attachment 86496] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 22 13:17:39 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 56859: Reduce float iteration in logicalLeft/RightOffsetForLine
https://bugs.webkit.org/show_bug.cgi?id=56859

Attachment 86496: Patch
https://bugs.webkit.org/attachment.cgi?id=86496&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=86496&action=review

> Source/WebCore/ChangeLog:10
> +	   Floats in the floating object list occur in the order that they are
positioned.  This means
> +	   that for a given vertical offset, the last left object in the list
that intersects that offset
> +	   will be the rightmost float.  There is no need to check any previous
floats, since they have to be
> +	   further left than that rightmost float.  The same rules hold true
for right-aligned floats.

One space after periods!


More information about the webkit-reviews mailing list