[webkit-reviews] review granted: [Bug 56692] Add high-quality band-limited audio resampling algorithm : [Attachment 86490] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 56692: Add high-quality band-limited audio resampling algorithm
https://bugs.webkit.org/show_bug.cgi?id=56692

Attachment 86490: Patch
https://bugs.webkit.org/attachment.cgi?id=86490&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=86490&action=review

Looks better, thanks. Couple of additional minor issues you can fix upon
landing.

> Source/WebCore/platform/audio/SincResampler.cpp:165
> +    while (numberOfDestinationFrames > 0) {

numberOfDestinationFrames is unsigned, so this test is not well written. Would
be better as "while (numberOfDestinationFrames)".

> Source/WebCore/platform/audio/SincResampler.cpp:316
> +	       numberOfDestinationFrames--;

In WebKit, prefer predecrement (--numberOfDestinationFrames).