[webkit-reviews] review denied: [Bug 56780] Solve the Assertions.cpp / -Wno-missing-format-attribute mystery : [Attachment 86386] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 21 16:50:46 PDT 2011
Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 56780: Solve the Assertions.cpp / -Wno-missing-format-attribute mystery
https://bugs.webkit.org/show_bug.cgi?id=56780
Attachment 86386: Patch
https://bugs.webkit.org/attachment.cgi?id=86386&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86386&action=review
> Source/JavaScriptCore/wtf/Assertions.cpp:29
> +#pragma GCC diagnostic ignored "-Wmissing-format-attribute"
You should comment as to why this is needed for this file (so it has a prayer
of being removed some day.
More information about the webkit-reviews
mailing list