[webkit-reviews] review requested: [Bug 56781] Add --dsym switch to enable dsym generation when building with Xcode : [Attachment 86387] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 21 16:49:45 PDT 2011


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 56781: Add --dsym switch to enable dsym generation when building with Xcode
https://bugs.webkit.org/show_bug.cgi?id=56781

Attachment 86387: Patch
https://bugs.webkit.org/attachment.cgi?id=86387&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

* Scripts/build-webkit: Updated usage statement to include
--dsym.
* Scripts/webkitdirs.pm: Added $generateDsym variable.
(generateDsym): Added. Call determineGenerateDsym() and
return $generateDsym.
(determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
$generateDsym.
(argumentsForXcode): Added.  Returns additional arguments for
xcodebuild based on command-line switches.
(XcodeOptions): Updated to include argumentsForXcode() in the
array returned.
---
 3 files changed, 40 insertions(+), 1 deletions(-)


More information about the webkit-reviews mailing list