[webkit-reviews] review requested: [Bug 56323] [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree : [Attachment 86079] patch5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 17 12:24:00 PDT 2011


qi <qi.2.zhang at nokia.com> has asked  for review:
Bug 56323: [Qt] Add a command line option to capture stdout and stderr for
DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=56323

Attachment 86079: patch5
https://bugs.webkit.org/attachment.cgi?id=86079&action=review

------- Additional Comments from qi <qi.2.zhang at nokia.com>
Change based on discussion with Laszlo and comments from Benjamin.

1. Make the redirect work for standalone mode and "-" mode.
2. Because 1, I move the code for starting redirect into main.cpp.
3. Changed DumpRenderTreeQt.h based on Benjanmin's comments.
4. Based Benjanmin's comments, "-bac.html" is valid test case name. The
assumption to get test case name is wrong, I make a function to identify the
option name, then all the others will be consider as valid option value.
5. Changed the redirection option name as "--stdout" and "--stderr"


More information about the webkit-reviews mailing list