[webkit-reviews] review denied: [Bug 19793] Web Inspector Gives Different Results on Tiger and Leopard (should show compressed size) : [Attachment 86073] Patch follow-up

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 19793: Web Inspector Gives Different Results on Tiger and Leopard (should
show compressed size)
https://bugs.webkit.org/show_bug.cgi?id=19793

Attachment 86073: Patch follow-up
https://bugs.webkit.org/attachment.cgi?id=86073&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86073&action=review

> LayoutTests/http/tests/inspector/network/network-size-chunked.html:16
> +    if (++loadedResourceCount === 1) {

I don't think you need a counter here.

> LayoutTests/http/tests/inspector/network/network-size-chunked.html:25
> +    InspectorTest.evaluateInPage("loadPages()");

Where is loadPages?

> LayoutTests/platform/chromium/test_expectations.txt:3190
> +BUG_VSEVIK SKIP : http/tests/inspector/network/network-size-chunked.html =
FAIL

Could you please file a bug for all of these?

> Source/WebCore/inspector/front-end/Resource.js:244
> +	   if (this._transferSize)

What about 0?

> Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp:561
> +    InspectorInstrumentation::didReceiveContentLength(m_frame,
m_currentResourceIdentifier, length, -1);

No traffic here.

> Source/WebCore/platform/network/mac/ResourceHandleMac.mm:926
> +    m_handle->client()->didReceiveData(m_handle, (const char*)[data bytes],
[data length], -1);

Put a FIXME and a bug reference here.