[webkit-reviews] review granted: [Bug 56076] rebaseline-chromium-webkit-tests should ignore reftests. : [Attachment 86025] treat-it-as-error

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 17 09:58:48 PDT 2011


Tony Chang <tony at chromium.org> has granted Hayato Ito <hayato at chromium.org>'s
request for review:
Bug 56076: rebaseline-chromium-webkit-tests should ignore reftests.
https://bugs.webkit.org/show_bug.cgi?id=56076

Attachment 86025: treat-it-as-error
https://bugs.webkit.org/attachment.cgi?id=86025&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86025&action=review

> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:242
> +	     False if reftests are wrongly marked as 'needs rebaseliing' or
True

rebaseliing -> rebaselining

> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:257
> +		   self._rebaselining_tests = []

Nit: Should this be set()?  Maybe __init__ should use set() too.


More information about the webkit-reviews mailing list