[webkit-reviews] review denied: [Bug 56458] User media videoconferencing patch 0: adding compilation guards : [Attachment 86049] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 17 09:55:05 PDT 2011


Eric Carlson <eric.carlson at apple.com> has denied Leandro Graciá Gil
<leandrogracia at chromium.org>'s request for review:
Bug 56458: User media videoconferencing patch 0: adding compilation guards
https://bugs.webkit.org/show_bug.cgi?id=56458

Attachment 86049: Patch
https://bugs.webkit.org/attachment.cgi?id=86049&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=86049&action=review

> Source/WebKit/chromium/features.gypi:86
> +	   'ENABLE_USER_MEDIA=1',

'ENABLE_USER_MEDIA' doesn't tell me anything about what feature it enables. I
realize that the spec uses "user media" in the interface names, eg.
NavigatorUserMedia, getUserMedia(), etc, but the term didn't mean anything to
me until I looked at the spec and it even after reading the spec it doesn't
make me think  "video conferencing". 

I don't have any great suggestions, maybe 'ENABLE_MEDIA_STREAM_API'?


More information about the webkit-reviews mailing list