[webkit-reviews] review denied: [Bug 38690] Submitting a POST that leads to a server redirect causes all cached items to redownload : [Attachment 83587] with ChangeLogs this time

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 14 12:21:16 PDT 2011


Brady Eidson <beidson at apple.com> has denied Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 38690: Submitting a POST that leads to a server redirect causes all cached
items to redownload
https://bugs.webkit.org/show_bug.cgi?id=38690

Attachment 83587: with ChangeLogs this time
https://bugs.webkit.org/attachment.cgi?id=83587&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=83587&action=review

>>> Source/WebCore/page/Settings.h:372
>>> +	     void setUseQuickLookResourceCachingQuirks(bool flag) {
m_useQuickLookResourceCachingQuirks = flag; }
>> 
>> Is this a chromium-only thing?
> 
> It's going to be used only for the QuickLook app.  I was assuming that that
was in private Apple code and that I couldn't actually set it myself, but if
I'm wrong, let me know. :)

Where's the WebKit/mac code that does the bundle check and actually sets the
flag?

Without that code, this patch breaks things in the way previously discussed.


More information about the webkit-reviews mailing list