[webkit-reviews] review denied: [Bug 45164] REGRESSION: <a><img align=top></a> Clickable area too large : [Attachment 76489] proposed patch(2nd)

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied My Shin <my.shin at obigo.com>'s request
for review:
Bug 45164: REGRESSION: <a><img align=top></a> Clickable area too large
https://bugs.webkit.org/show_bug.cgi?id=45164

Attachment 76489: proposed patch(2nd)
https://bugs.webkit.org/attachment.cgi?id=76489&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=76489&action=review

This isn't right.

> WebCore/rendering/InlineFlowBox.cpp:597
> +	       int posAdjust = 0;
>	       if ((isInlineFlow &&
!static_cast<InlineFlowBox*>(curr)->hasTextChildren()) &&
!curr->boxModelObject()->hasInlineDirectionBordersOrPadding() && !strictMode)
>		   childAffectsTopBottomPos = false;
> -	       int posAdjust = maxAscent -
curr->baselinePosition(baselineType);
> +	       else
> +		   posAdjust = maxAscent -
curr->baselinePosition(baselineType);

I don't understand this at all.  There's nothing wrong with this code as far as
I can tell.  You still have to set the correct logicalTop.  You can't just
leave it at 0.