[webkit-reviews] review granted: [Bug 56030] Leaks Viewer: Would like to be able to look at all leaks files from a particular build at once, rather than one at a time : [Attachment 85486] Make it possible to view all leaks from a build at once in Leaks Viewer

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 56030: Leaks Viewer: Would like to be able to look at all leaks files from
a particular build at once, rather than one at a time
https://bugs.webkit.org/show_bug.cgi?id=56030

Attachment 85486: Make it possible to view all leaks from a build at once in
Leaks Viewer
https://bugs.webkit.org/attachment.cgi?id=85486&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85486&action=review

r=me

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.h
tml:58
> +    <script src=LeaksLoader.js></script>
> +    <script src=LeaksParser.js></script>
>      <script src=LeaksViewer.js></script>
> +    <script src=Utilities.js></script>

Nit: You should really use double-quotes around the value of the src
attributes.

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.h
tml:65
> +	       <span id=loading-indicator-label>Loading…</span>

Nit: And around the id attribute.