[webkit-reviews] review granted: [Bug 52468] REGRESSION (5.0.3-ToT): Scrolling text doesn't scroll in Star Wars intro animation : [Attachment 85490] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 52468: REGRESSION (5.0.3-ToT): Scrolling text doesn't scroll in Star Wars
intro animation
https://bugs.webkit.org/show_bug.cgi?id=52468

Attachment 85490: Patch
https://bugs.webkit.org/attachment.cgi?id=85490&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85490&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1604
> +#if defined(BUILDING_ON_LEOPARD) || defined(BUILDING_ON_SNOW_LEOPARD) ||
defined(WIN32)

PLATFORM(WIN), please.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1608
> +	   // FIXME: This fix has not been added to the Safari Windows SDK yet
(<rdar://problem/9112233>) so we expect the
> +	   // reversed animation behavior

I'd say "QuartzCore on Windows" rather than "the Safari Windows SDK".