[webkit-reviews] review granted: [Bug 55660] [WK2] Make non-transparent windowless plugins paint on X11 : [Attachment 85172] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 55660: [WK2] Make non-transparent windowless plugins paint on X11
https://bugs.webkit.org/show_bug.cgi?id=55660

Attachment 85172: Patch
https://bugs.webkit.org/attachment.cgi?id=85172&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85172&action=review

Looks like a good start, r=me. :)

> Source/WebKit2/ChangeLog:24
> +	   * WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp: Removed in
favour
> +	   of a common implementation for X11.

We should remove NetscapePluginGtk.cpp as well.

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1223
> +	   // Inject wmode=opaque to make Flash working with these conditions.

s/working with/work in/