[webkit-reviews] review granted: [Bug 56089] [GTK] run-gtk-tests doesn't fail if a test crashes : [Attachment 85307] proposed patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 56089: [GTK] run-gtk-tests doesn't fail if a test crashes
https://bugs.webkit.org/show_bug.cgi?id=56089

Attachment 85307: proposed patch
https://bugs.webkit.org/attachment.cgi?id=85307&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85307&action=review

> Tools/Scripts/run-gtk-tests:41
> +    if (!$exitStatus && $?) {
> +	   $exitStatus = $?;

No need to check whether exitstatus is already set, I think, just check that $?
is non-zero and assign unconditionally.