[webkit-reviews] review denied: [Bug 21222] Formatted Diff for attachment 23920 is mangled : [Attachment 85129] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 9 05:23:04 PST 2011
Adam Roben (:aroben) <aroben at apple.com> has denied Caio Marcelo de Oliveira
Filho <caio.oliveira at openbossa.org>'s request for review:
Bug 21222: Formatted Diff for attachment 23920 is mangled
https://bugs.webkit.org/show_bug.cgi?id=21222
Attachment 85129: patch
https://bugs.webkit.org/attachment.cgi?id=85129&action=review
------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
I agree with Eric that the line-ending normalization should happen in
PrettyPatch itself. prettify.rb is just supposed to be a thin wrapper around
PrettyPatch.
More information about the webkit-reviews
mailing list