[webkit-reviews] review granted: [Bug 55986] Use the Cookie Storage from the Private Browsing Storage Session directly : [Attachment 85119] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 9 05:15:52 PST 2011


Adam Roben (:aroben) <aroben at apple.com> has granted Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 55986: Use the Cookie Storage from the Private Browsing Storage Session
directly
https://bugs.webkit.org/show_bug.cgi?id=55986

Attachment 85119: Patch
https://bugs.webkit.org/attachment.cgi?id=85119&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85119&action=review

Why doesn't Mac need the CreateInMemory fallback path?

> Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp:81
> +	   privateBrowsingCookieStorage() =
wkCreateInMemoryHTTPCookieStorage();

You're leaking this CFHTTPCookieStorageRef.


More information about the webkit-reviews mailing list