[webkit-reviews] review denied: [Bug 55823] Web Inspector: re-implement breakpoints sidebar pane as a simple ui component. : [Attachment 85159] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 9 05:12:12 PST 2011


Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 55823: Web Inspector: re-implement breakpoints sidebar pane as a simple ui
component.
https://bugs.webkit.org/show_bug.cgi?id=55823

Attachment 85159: Patch.
https://bugs.webkit.org/attachment.cgi?id=85159&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Could you please explain why are you doing this refactoring? Bug title says:
"re-implement breakpoints sidebar pane as a simple ui component", but I see
this._model being introduced in the sidebar section class. I.e. the opposite is
happening. I am fine with having model in the sidebar, but I am confused wrt
what exactly is happening and why.


More information about the webkit-reviews mailing list