[webkit-reviews] review denied: [Bug 44311] Web Inspector: elements dom tree - word wrap toggle : [Attachment 85161] [PATCH] Comments addressed, added revealing of the element's left boundary (if necessary)

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 44311: Web Inspector: elements dom tree - word wrap toggle
https://bugs.webkit.org/show_bug.cgi?id=44311

Attachment 85161: [PATCH] Comments addressed, added revealing of the element's
left boundary (if necessary)
https://bugs.webkit.org/attachment.cgi?id=85161&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85161&action=review

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:188
> +	   var container = this.element.parentElement;

What is wrong with the native implementation? We should use platform
capabilities where possible.

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:201
> +	   // items extend nearly to the right edge of the outer <ol>. However,


You could do:
var scrollContainerElement = this.element.parentElement;
and then leave old code changed to using scrollContainerElement.