[webkit-reviews] review denied: [Bug 55927] Emulate shebang on Win32 : [Attachment 85032] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 55927: Emulate shebang on Win32
https://bugs.webkit.org/show_bug.cgi?id=55927

Attachment 85032: Patch
https://bugs.webkit.org/attachment.cgi?id=85032&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85032&action=review

> Tools/Scripts/webkitpy/common/config/ports.py:55
> +	       first_line = open(script_file, "r").readline()
> +	       if first_line.startswith("#!"):
> +		   if first_line.find("python") > -1:
> +		       return [sys.executable, script_file]
> +		   if first_line.find("perl") > -1:

I would have split this off into a separate function (which would then be
unit-testable).  Something like interpreter_for_script, or something.

In general this looks fine. I'm not sure how much this slows down execution.

I'm ready to r+ this with a unit test.	(See filesystem.py and
filesystem_mock.py for how we do open and test open)