[webkit-reviews] review granted: [Bug 51357] REGRESSION (r66428/r71892): Crash after assertion failure (!m_reachedTerminalState) in ResourceLoader::didCancel() : [Attachment 85033] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 51357: REGRESSION (r66428/r71892): Crash after assertion failure
(!m_reachedTerminalState) in ResourceLoader::didCancel()
https://bugs.webkit.org/show_bug.cgi?id=51357

Attachment 85033: Patch
https://bugs.webkit.org/attachment.cgi?id=85033&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=85033&action=review

> Source/WebCore/page/DOMWindow.cpp:1632
> +	   m_printTimer.stop();
> +	   m_printTimer.startOneShot(0);

There is no need to call stop before start on a Timer. Calling any version of
start automatically cancels any previously-scheduler timer as stop does.