[webkit-reviews] review granted: [Bug 55115] Add support for DataTransferItems : [Attachment 85010] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Daniel Cheng
<dcheng at chromium.org>'s request for review:
Bug 55115: Add support for DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=55115

Attachment 85010: Patch
https://bugs.webkit.org/attachment.cgi?id=85010&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85010&action=review

Please fix the items commented on and check in.

> Source/WebCore/dom/DataTransferItem.h:44
> +public:

Need virtual destructor.

> Source/WebCore/dom/DataTransferItems.h:46
> +public:

Add virtual destructor.

> Source/WebCore/dom/StringCallback.cpp:43
> +    static DispatchCallbackTask* create(PassRefPtr<StringCallback> callback,
const String& data)

return type should be PassOwnPtr<>

> Source/WebCore/dom/StringCallback.cpp:45
> +	   return new DispatchCallbackTask(callback, data);

Should be "return adoptPtr(new ..."