[webkit-reviews] review canceled: [Bug 55811] Fix webkit-patch on Win32 python : [Attachment 84838] Patch

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has canceled Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 55811: Fix webkit-patch on Win32 python
https://bugs.webkit.org/show_bug.cgi?id=55811

Attachment 84838: Patch
https://bugs.webkit.org/attachment.cgi?id=84838&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84838&action=review

>> Tools/Scripts/webkitpy/common/config/ports.py:43
>> +	    return "Tools/Scripts/" + script_name
> 
> Are you sure this is really what we want?  I would suspect this is used in
other places which might want a \ instead on windows.

I don't like this too, but if i keep the backslash Win32 perl fail, because it
can't find VCSUtils module. I'll try if passing the include directory via
command line works.

>> Tools/Scripts/webkitpy/common/config/ports.py:92
>> +	    command = [cls.perl_executable(), cls.script_path("build-webkit")]
> 
> This is kinda sad.  To encode the perl vs. python in the caller.  I take it
there is no way to run these under a shell in naked win32?

Nope :-(, you find the same change in the previous "Win32 fixes".