[webkit-reviews] review denied: [Bug 54877] chrome.dll!WebCore::HTMLAreaElement::setFocus ReadAV at NULL (2f8e4496f8ea69da13971f5fddd09753) : [Attachment 84223] Patch

Tue Mar 1 09:53:57 PST 2011

Eric Seidel <eric at webkit.org> has denied SkyLined <skylined at chromium.org>'s
request for review:
Bug 54877: chrome.dll!WebCore::HTMLAreaElement::setFocus ReadAV at NULL
(2f8e4496f8ea69da13971f5fddd09753)
https://bugs.webkit.org/show_bug.cgi?id=54877

Attachment 84223: Patch
https://bugs.webkit.org/attachment.cgi?id=84223&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84223&action=review

Otherwise seems fine to me.

> LayoutTests/ChangeLog:16
> +2011-03-01  BJ Wever  <skylined at chromium.org>
> +

Double ChangeLog.

> LayoutTests/fast/dom/HTMLAreaElement/area-islink-focus-null-ptr-crash.html:31

> +  <body onload="go()">

This doens't need to be in on onload, and doesn't need to be in the head.  You
don't even need the rest of the document.  I woul djust have a <script> tag
with your 3 lines of JS.   Something like this:

<div id="log">FAIL</div>
<script>
var area = document.createElement("area");
area.href = 0;
area.focus();
log.innerHTML = "PASS, did not crash";
</script>

And that should be your whole test. :)