[webkit-reviews] review granted: [Bug 54910] media/video-replaces-poster.html fails on all platforms : [Attachment 84132] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Anna Cavender
<annacc at chromium.org>'s request for review:
Bug 54910: media/video-replaces-poster.html fails on all platforms
https://bugs.webkit.org/show_bug.cgi?id=54910

Attachment 84132: Patch
https://bugs.webkit.org/attachment.cgi?id=84132&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84132&action=review

r+ but I would prefer to have at least the comment updated before landing.

> LayoutTests/media/video-replaces-poster.html:25
> +	   function checkExpected(actual, expected)
> +	   {
> +	       if (actual != expected)
> +		   document.writeln("<p>FAILURE: expected " + expected + ",
actual " + actual + "</p>");
> +	   }

As long as this test needs to be updated, can you include video-test.js and use
one of its functions?

> LayoutTests/media/video-replaces-poster.html:31
>      You should see the video play below.</p>

This comment is no longer correct.