[webkit-reviews] review granted: [Bug 63358] nrwt: remove --use-apache from the command line : [Attachment 98549] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 28 18:20:32 PDT 2011


Adam Barth <abarth at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 63358: nrwt: remove --use-apache from the command line
https://bugs.webkit.org/show_bug.cgi?id=63358

Attachment 98549: Patch
https://bugs.webkit.org/attachment.cgi?id=98549&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98549&action=review

> Tools/Scripts/webkitpy/layout_tests/port/base.py:848
> +	   """Override if your port uses something other than Apache for
serving
> +	   web pages."""

I'd skip this docstring

> Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py:58
> +    USES_APACHE = False

This appears to be unused.


More information about the webkit-reviews mailing list