[webkit-reviews] review requested: [Bug 63591] [Chromium] isRedirect is incorrectly determined for decidePolicyForNavigation : [Attachment 99017] Patch to fix this bug.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 28 18:15:33 PDT 2011


Ben Smith <binji at chromium.org> has asked  for review:
Bug 63591: [Chromium] isRedirect is incorrectly determined for
decidePolicyForNavigation
https://bugs.webkit.org/show_bug.cgi?id=63591

Attachment 99017: Patch to fix this bug.
https://bugs.webkit.org/attachment.cgi?id=99017&action=review

------- Additional Comments from Ben Smith <binji at chromium.org>
In FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction()

isRedirect is currently determined by hasRedirectChain(), which checks for an
non-empty redirect chain. Instead, it should check for a redirect chain with
more than one element. All valid redirects will have at least the source URL
and the destination URL in the redirect chain.


More information about the webkit-reviews mailing list