[webkit-reviews] review requested: [Bug 63362] convert editing/deleting/paragraph-in-preserveNewline.html to dumpAsText : [Attachment 98956] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 28 12:15:38 PDT 2011


Wyatt Carss <wcarss at chromium.org> has asked  for review:
Bug 63362: convert editing/deleting/paragraph-in-preserveNewline.html to
dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=63362

Attachment 98956: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=98956&action=review

------- Additional Comments from Wyatt Carss <wcarss at chromium.org>
Hopefully this works - I manually made the patch file using 'git diff -M100
commit-number'. The upload script generates a diff somewhere, and git's dumb
"smart rename tracking" which only comes to the surfaces when generating diffs
causes the file not to be shown. Passing -M100 or --no-renames to the diff line
keeps it from finding renames, which is great - but modifying the upload script
to include either of these in calls to git diff didn't seem to have an effect.

Anyway, since webkit-patch doesn't have the ability to pretty-preview an
arbitrary patch from a file, and I don't fully trust my ability to read raw
diffs, I'll know after uploading this whether the manual diff worked quite the
way I wanted.


More information about the webkit-reviews mailing list