[webkit-reviews] review granted: [Bug 63384] Stop instantiating Position with PositionIsOffsetInAnchor in various files : [Attachment 98951] Fixed per comments

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 63384: Stop instantiating Position with PositionIsOffsetInAnchor in various
files
https://bugs.webkit.org/show_bug.cgi?id=63384

Attachment 98951: Fixed per comments
https://bugs.webkit.org/attachment.cgi?id=98951&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98951&action=review

> Source/WebCore/dom/Position.cpp:156
> +	       return m_anchorNode && m_anchorNode->isTextNode() ?
static_cast<Text*>(m_anchorNode.get()) : 0;

Wrong indentation here.

> Source/WebCore/editing/ApplyStyleCommand.cpp:1130
> +    updateStartEnd(firstPositionInNode(start.containerNode()), newEnd);

This could be text instead of start.containerNode().

> Source/WebCore/editing/VisiblePosition.cpp:-557
> -    unsigned length = textNode->length();

Why did you get rid of this local variable?