[webkit-reviews] review granted: [Bug 63496] [Qt] DRT support for setInteractiveFormValidationEnabled : [Attachment 98821] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 28 01:43:54 PDT 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Diego Gonzalez
<diegohcg at webkit.org>'s request for review:
Bug 63496: [Qt] DRT support for setInteractiveFormValidationEnabled
https://bugs.webkit.org/show_bug.cgi?id=63496

Attachment 98821: Patch
https://bugs.webkit.org/attachment.cgi?id=98821&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98821&action=review

> Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:1012
> +void DumpRenderTreeSupportQt::setInteractiveFormValidationEnabled(QWebPage*
page, bool flag)

flag is a pretty bad name for a bool. what about 'bool enable'


More information about the webkit-reviews mailing list