[webkit-reviews] review granted: [Bug 63519] Refactor RenderTextControl::text(). : [Attachment 98878] Patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 63519: Refactor RenderTextControl::text().
https://bugs.webkit.org/show_bug.cgi?id=63519

Attachment 98878: Patch
https://bugs.webkit.org/attachment.cgi?id=98878&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98878&action=review

>>> Source/WebCore/rendering/RenderTextControl.cpp:337
>>> +static String finishText(StringBuilder& result)
>> 
>> Another possible idea would be introducing a small class
>> which wraps or subclasses StringBuilder, and make it build these two types
of text.
>> This kind of out-parameter looks kind of horrible for me. 
>> What do you think?
> 
> I feel it's overkill in this case.

Okay, let's just land this.