[webkit-reviews] review denied: [Bug 63372] convert editing/deleting/whitespace-pre-1.html to dumpAsText : [Attachment 98570] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 24 18:53:27 PDT 2011
Ryosuke Niwa <rniwa at webkit.org> has denied Wyatt Carss <wcarss at chromium.org>'s
request for review:
Bug 63372: convert editing/deleting/whitespace-pre-1.html to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=63372
Attachment 98570: Patch
https://bugs.webkit.org/attachment.cgi?id=98570&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98570&action=review
> LayoutTests/editing/deleting/whitespace-pre-1.html:4
> if (window.layoutTestController)
> layoutTestController.dumpEditingCallbacks();
> + layoutTestController.dumpAsText();
You need curly brackets around these two statements. Otherwise, we'll get
script errors when we run it manually on a browser. Also I'd use
dump-as-markup.js to see the markup.
More information about the webkit-reviews
mailing list